[clang-tidy] Use const reference instead of initializing string
Found with performance-unnecessary-copy-initialization Signed-off-by: Rosen Penev <rosenp@gmail.com>
This commit is contained in:
committed by
Paul Beckingham
parent
e3ceda9ce1
commit
ab170e34df
@@ -242,7 +242,7 @@ static bool sort_compare (int left, int right)
|
||||
// UDAs.
|
||||
else if ((column = Context::getContext ().columns[field]) != nullptr)
|
||||
{
|
||||
std::string type = column->type ();
|
||||
const std::string& type = column->type ();
|
||||
if (type == "numeric")
|
||||
{
|
||||
auto left_real = strtof (((*global_data)[left].get_ref (field)).c_str (), nullptr);
|
||||
|
||||
Reference in New Issue
Block a user