- While fixing bug.360.t, discovered a bigger problem, which is not yet fixed. When a due date is removed from a recurring child task, the imask, parent and recur attributes should also be removed. Similarly when a recur frequency is removed from a recurring child task, the imask and parent should also be removed. - Net result: two new failing tests.
177 lines
5.7 KiB
C++
177 lines
5.7 KiB
C++
////////////////////////////////////////////////////////////////////////////////
|
|
// taskwarrior - a command line task list manager.
|
|
//
|
|
// Copyright 2006 - 2011, Paul Beckingham, Federico Hernandez.
|
|
// All rights reserved.
|
|
//
|
|
// This program is free software; you can redistribute it and/or modify it under
|
|
// the terms of the GNU General Public License as published by the Free Software
|
|
// Foundation; either version 2 of the License, or (at your option) any later
|
|
// version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful, but WITHOUT
|
|
// ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
|
|
// FOR A PARTICULAR PURPOSE. See the GNU General Public License for more
|
|
// details.
|
|
//
|
|
// You should have received a copy of the GNU General Public License along with
|
|
// this program; if not, write to the
|
|
//
|
|
// Free Software Foundation, Inc.,
|
|
// 51 Franklin Street, Fifth Floor,
|
|
// Boston, MA
|
|
// 02110-1301
|
|
// USA
|
|
//
|
|
////////////////////////////////////////////////////////////////////////////////
|
|
|
|
#include <iostream>
|
|
#include <sstream>
|
|
#include <Context.h>
|
|
#include <Permission.h>
|
|
#include <main.h>
|
|
#include <text.h>
|
|
#include <i18n.h>
|
|
#include <CmdModify.h>
|
|
|
|
extern Context context;
|
|
|
|
////////////////////////////////////////////////////////////////////////////////
|
|
CmdModify::CmdModify ()
|
|
{
|
|
_keyword = "modify";
|
|
_usage = "task <filter> modify <modifications>\n"
|
|
"task <sequence> <modifications>";
|
|
_description = "Modifies the existing task with provided arguments.\n"
|
|
"The 'modify' keyword is optional.";
|
|
_read_only = false;
|
|
_displays_id = false;
|
|
}
|
|
|
|
////////////////////////////////////////////////////////////////////////////////
|
|
int CmdModify::execute (std::string& output)
|
|
{
|
|
int count = 0;
|
|
std::stringstream out;
|
|
|
|
// Apply filter.
|
|
std::vector <Task> filtered;
|
|
filter (filtered);
|
|
if (filtered.size () == 0)
|
|
{
|
|
context.footnote (STRING_FEEDBACK_NO_TASKS_SP);
|
|
return 1;
|
|
}
|
|
|
|
// Apply the command line modifications to the new task.
|
|
A3 modifications = context.a3.extract_modifications ();
|
|
if (!modifications.size ())
|
|
throw std::string (STRING_CMD_XPEND_NEED_TEXT);
|
|
|
|
Permission permission;
|
|
if (filtered.size () > (size_t) context.config.getInteger ("bulk"))
|
|
permission.bigSequence ();
|
|
|
|
std::vector <Task>::iterator task;
|
|
for (task = filtered.begin (); task != filtered.end (); ++task)
|
|
{
|
|
Task before (*task);
|
|
modify_task_description_replace (*task, modifications);
|
|
|
|
// Perform some logical consistency checks.
|
|
if (task->has ("recur") &&
|
|
!task->has ("due") &&
|
|
!before.has ("due"))
|
|
throw std::string ("You cannot specify a recurring task without a due date.");
|
|
|
|
if (task->has ("until") &&
|
|
!task->has ("recur") &&
|
|
!before.has ("recur"))
|
|
throw std::string ("You cannot specify an until date for a non-recurring task.");
|
|
|
|
if (before.has ("recur") &&
|
|
before.has ("due") &&
|
|
(!task->has ("due") ||
|
|
task->get ("due") == ""))
|
|
throw std::string ("You cannot remove the due date from a recurring task.");
|
|
|
|
if (before.has ("recur") &&
|
|
task->has ("recur") &&
|
|
(!task->has ("recur") ||
|
|
task->get ("recur") == ""))
|
|
throw std::string ("You cannot remove the recurrence from a recurring task.");
|
|
|
|
if (taskDiff (before, *task) &&
|
|
permission.confirmed (*task, taskDifferences (before, *task) + "Proceed with change?"))
|
|
{
|
|
// Checks passed, modify the task.
|
|
++count;
|
|
context.tdb2.modify (*task);
|
|
if (before.get ("project") != task->get ("project"))
|
|
context.footnote (onProjectChange (before, *task));
|
|
|
|
// Make all changes.
|
|
bool warned = false;
|
|
std::vector <Task> siblings = context.tdb2.siblings (*task);
|
|
std::vector <Task>::iterator sibling;
|
|
for (sibling = siblings.begin (); sibling != siblings.end (); ++sibling)
|
|
{
|
|
if (before.has ("parent") && !warned)
|
|
{
|
|
warned = true;
|
|
std::cout << "Task "
|
|
<< before.id
|
|
<< " is a recurring task, and all other instances of this"
|
|
<< " task will be modified.\n";
|
|
}
|
|
|
|
Task alternate (*sibling);
|
|
|
|
// If a task is being made recurring, there are other cascading
|
|
// changes.
|
|
if (!before.has ("recur") &&
|
|
task->has ("recur"))
|
|
{
|
|
sibling->setStatus (Task::recurring);
|
|
sibling->set ("mask", "");
|
|
|
|
std::cout << "Task "
|
|
<< sibling->id
|
|
<< " is now a recurring task.\n";
|
|
}
|
|
|
|
// Apply other deltas.
|
|
modify_task_description_replace (*sibling, modifications);
|
|
|
|
if (taskDiff (alternate, *sibling))
|
|
{
|
|
if (permission.confirmed (alternate, taskDifferences (alternate, *sibling) + "Proceed with change?"))
|
|
{
|
|
// TODO Are dependencies being explicitly removed?
|
|
// Either we scan context.task for negative IDs "depends:-n"
|
|
// or we ask deltaAttributes (above) to record dependency
|
|
// removal.
|
|
dependencyChainOnModify (alternate, *sibling);
|
|
context.tdb2.modify (*sibling);
|
|
++count;
|
|
|
|
if (alternate.get ("project") != sibling->get ("project"))
|
|
context.footnote (onProjectChange (alternate, *sibling));
|
|
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
context.tdb2.commit ();
|
|
|
|
if (context.config.getBoolean ("echo.command"))
|
|
out << "Modified " << count << " task" << (count == 1 ? ".\n" : "s.\n");
|
|
|
|
output = out.str ();
|
|
return 0;
|
|
}
|
|
|
|
////////////////////////////////////////////////////////////////////////////////
|