gergely/taskwarrior-2.x
1
0
Fork 0
Code Issues Actions Packages Projects Releases 1 Wiki Activity
9,393 Commits 5 Branches 55 Tags
413b8d22b7b4134c080e1a8eb7c965c60d84825e
Commit Graph

407 Commits

Author SHA1 Message Date
Dustin J. Mitchell
413b8d22b7 Remove references to the 'depends' property outside of Task.cpp 
With the exception of `taskDifferences` and `taskInfoDifferences`,
deferred to #2572.
 2021-08-17 20:36:54 -04:00
Tomas Babej
f8ca8cff81 Task: Make COMPLETED and DELETED virtual tags use getStatus() 
This is now consistent with how PENDING is defined since recent commit
520d7e979b17c90e91d29325be8294905b338ee6.
 2021-08-08 14:27:25 -04:00
Tomas Babej
91517151ad docs: Add removal comments 2021-08-08 14:27:25 -04:00
Tomas Babej
ea008380db Task: Use getStatus () call to determine if task is pending 2021-08-08 14:27:25 -04:00
Dustin J. Mitchell
901283c79f [WIP] make 'waiting' status a 'virtual' status 2021-08-08 14:27:25 -04:00
Dustin J. Mitchell
20041c120e Refactor to store tags as individual attributes 
Each tag is stored as `tag_<tagname>: x`.  The `x` is required because
empty attributes are treated as nonexistent.

For compatibility, the `tags` attribute is updated in sync with the
per-tag attributes.  This compatibility support may be dropped in later
versions.

Note that synchronization _updates_ use JSON format, which does not
change with this patch, and thus no compatibility issues exist.  The
synchronization _initialization_, however, uses FF4, meaning that a
sync server initialized from a version of `task` with this patch will
contain `tag_<tagname>` attributes, which will look like orphaned UDAs
to older versions.  However, as updates to tasks are synchronized via
the sync server, the updates will not contain these attributes and they
will show as "deleted" in the `task info` display on the older version.
Aside from the noise in the `task info` output, this is harmless.
 2021-08-05 02:11:27 -04:00
Rosen Penev
5c137f5c8f use emplace 
Allows removing the constructor name as emplace forwards the arguments
directly.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-08-05 02:03:59 -04:00
Vladyslav Tronko
af6f2b55ec Fix matching project name during urgency calculation 2021-07-17 16:21:59 -04:00
Tomas Babej
8f7e41b392 parseJSON: Allow annotations with missing entry values 
This relaxes previous stringent requirements on the input values during
import.

Closes #1804.
 2021-06-23 00:13:03 -04:00
Tomas Babej
6d81acd355 parseJSON: Ensure NULL values from failed lookups do not persist 
The operator[] insets values if the lookup fails, which creates null
pointers.

See: https://en.cppreference.com/w/cpp/container/map/operator_at
 2021-06-23 00:13:03 -04:00
Tomas Babej
a219bd30cf Task: Bump annotations with duplicate entry values 
Since annotations are stored as a map, duplicate entry values lead to
data loss (i.e. annotations overriding each other on import). Perhaps
the choice of using a map internally should be reconsidered.

Closes #1938.
 2021-06-19 12:29:41 -04:00
Tomas Babej
87d0499fc8 performance: Use ascii-only version of getUnitl for parsing attribute names 
Not having to consider utf-8 characters has performance benefits.
 2021-04-24 10:47:28 -04:00
Tomas Babej
312f77f703 performance: Do not use Pig to extract raw line content 2021-04-24 10:47:28 -04:00
Rosen Penev
15f0ab87e0 clang-tidy: use const references 
Found with performance-for-range-copy

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-04-23 01:59:45 -04:00
Rosen Penev
e84930be8d clang-tidy: use auto 
Found with modernize-use-auto

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-04-23 01:39:23 -04:00
Rosen Penev
04454a995f clang-tidy: use raw string literals 
Found with modernize-raw-string-literals

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-03-02 20:36:02 -05:00
Tomas Babej
9017cd6e53 doc: Update copyright to 2021 2021-01-02 02:48:22 -05:00
Tomas Babej
1a001caedd Task: Prevent double json-decoding of attribute values 
In bd4a7081, json-decoding of attribute values was introduced as a
workaround to properly handle blackslashes in description and
annotations (see TW-880).

However, this behaviour is no longer present with the new parser and
introduces its own suite of issues (i.e. see #2140).

Closes #2140.
 2020-12-31 14:23:55 -05:00
Tomas Babej
9ed047d46d Task: Support setting 64-bit integer values 
Thanks to Stephan Rieche.
 2020-12-27 21:29:15 -05:00
Paul Beckingham
3e0a428185 Revert "[clang-tidy] Use .empty instead of comparing size" 
This reverts commit a331cceded.
 2020-12-05 16:18:37 -05:00
Paul Beckingham
b2d46a1eba Revert "[clang-tidy] Use auto where the type is known" 
This reverts commit 6ce2a129dd.
 2020-12-05 16:18:37 -05:00
Paul Beckingham
2652a9d3f1 Revert "[clang-tidy] Add const references where useful" 
This reverts commit 37b641259c.
 2020-12-05 16:18:37 -05:00
Paul Beckingham
5502729131 Revert "[clang-tidy] Switch C headers to C++ ones" 
This reverts commit 0344856d65.
 2020-12-05 16:18:37 -05:00
Paul Beckingham
9016c26828 Revert "[cl;ang-tidy] Don't initialize strings" 
This reverts commit 426e067f43.
 2020-12-05 16:18:37 -05:00
Paul Beckingham
702af00435 Revert "[clang-tidy] Remove redundant const" 
This reverts commit 55d103c491.
 2020-12-05 16:18:37 -05:00
Paul Beckingham
c43a513158 Revert "[clang-tidy] Replace C style casts with C++ ones" 
This reverts commit 13e1bf7204.
 2020-12-05 16:18:37 -05:00
Paul Beckingham
364b4ea8bd Revert "[clang-tidy] Simplify boolean expressions" 
This reverts commit 51870dff34.
 2020-12-05 16:18:37 -05:00
Paul Beckingham
623d5ceb59 Revert "[clang-tidy] using dynamic_cast for derived classes" 
This reverts commit a02754159c.
 2020-12-05 16:18:37 -05:00
Rosen Penev
a02754159c [clang-tidy] using dynamic_cast for derived classes 
Found with cppcoreguidelines-pro-type-cstyle-cast

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-12-05 15:03:43 -05:00
Rosen Penev
51870dff34 [clang-tidy] Simplify boolean expressions 
Found with readability-simplify-boolean-expr

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-12-05 15:03:43 -05:00
Rosen Penev
13e1bf7204 [clang-tidy] Replace C style casts with C++ ones 
Found with google-readability-casting

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-12-05 15:03:43 -05:00
Rosen Penev
55d103c491 [clang-tidy] Remove redundant const 
Found with readability-const-return-type

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-12-05 15:03:43 -05:00
Rosen Penev
426e067f43 [cl;ang-tidy] Don't initialize strings 
Found with readability-redundant-string-init

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-12-05 15:03:43 -05:00
Rosen Penev
0344856d65 [clang-tidy] Switch C headers to C++ ones 
Found using modernize-return-braced-init-list

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-12-05 15:03:43 -05:00
Rosen Penev
37b641259c [clang-tidy] Add const references where useful 
Found with performance-for-range-copy

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-12-05 15:03:43 -05:00
Rosen Penev
6ce2a129dd [clang-tidy] Use auto where the type is known 
Found with modernize-use-auto

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-12-05 15:03:43 -05:00
Rosen Penev
a331cceded [clang-tidy] Use .empty instead of comparing size 
Found with readability-container-size-empty

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-12-05 15:03:43 -05:00
Tomas Babej
a09f9d48ab Update copyright to 2020 2020-11-21 12:27:05 -05:00
javabird25
81183ae7d1 Fix SIGSEGV when substituting sequence with shorter one 2020-11-17 10:40:38 -05:00
Paul Beckingham
24943a441d Merge pull request #2076 from djmitche/task-decode-comment 
Docs: make comment on Task::decode match reality
 2019-01-02 08:02:58 -05:00
Tomas Babej
8066e4e6e2 meta: Update copyright year 2019-01-01 08:46:21 -05:00
Dustin J. Mitchell
f1599d8029 Docs: make comment on Task::decode match reality 2018-11-10 19:42:15 -05:00
Kirill Bobyrev
5cdbe6d019 Use nullptr instead lf C-styled NULL 2018-03-07 22:21:28 +03:00
Simon Ruderich
e817dfc800 Always use https:// link for opensource.org 
It was already used in a few places, make this consistent.
 2018-03-04 14:53:07 +01:00
Mark Scannell
7af6db4c17 Portability: Updated to make main re-entrant() 
- New INSTALL instructions to emscripten, and AUTHORS for contribution.
 2018-01-31 19:45:07 -05:00
Paul Beckingham
98b433bee3 l10n: Eliminated some column labels 2018-01-21 23:19:11 -05:00
Paul Beckingham
9188cb083c l10n: Eliminated STRING_CMD_IMPORT_* 2018-01-21 12:09:51 -05:00
Paul Beckingham
641b2dd412 l10n: Eliminated STRING_CMD_MODIFY_* 2018-01-20 15:40:22 -05:00
Paul Beckingham
5f6f61c591 l10n: Eliminated STRING_TASK_VALID_DESC 2018-01-20 14:45:38 -05:00
Paul Beckingham
e2d92bb2d6 l10n: Eliminated STRING_INVALID_MOD 2018-01-20 14:30:03 -05:00