diff --git a/src/columns/ColIMask.cpp b/src/columns/ColIMask.cpp index 7de699666..fbc090a20 100644 --- a/src/columns/ColIMask.cpp +++ b/src/columns/ColIMask.cpp @@ -45,7 +45,6 @@ ColumnIMask::ColumnIMask () void ColumnIMask::measure (Task& task, unsigned int& minimum, unsigned int& maximum) { minimum = maximum = 0; - if (task.has (_name)) { minimum = maximum = task.get (_name).length (); diff --git a/src/columns/ColParent.cpp b/src/columns/ColParent.cpp index 5222a3636..f24a67999 100644 --- a/src/columns/ColParent.cpp +++ b/src/columns/ColParent.cpp @@ -45,7 +45,6 @@ ColumnParent::ColumnParent () void ColumnParent::measure (Task& task, unsigned int& minimum, unsigned int& maximum) { minimum = maximum = 0; - if (task.has (_name)) { if (_style == "default" || _style == "long") minimum = maximum = 36; diff --git a/src/columns/ColProject.cpp b/src/columns/ColProject.cpp index aab4167a7..a24dfaa6a 100644 --- a/src/columns/ColProject.cpp +++ b/src/columns/ColProject.cpp @@ -59,7 +59,6 @@ ColumnProject::ColumnProject () void ColumnProject::measure (Task& task, unsigned int& minimum, unsigned int& maximum) { minimum = maximum = 0; - if (task.has (_name)) { std::string project = task.get (_name); diff --git a/src/columns/ColRecur.cpp b/src/columns/ColRecur.cpp index dccfaa2c0..59e1907f7 100644 --- a/src/columns/ColRecur.cpp +++ b/src/columns/ColRecur.cpp @@ -68,7 +68,6 @@ void ColumnRecur::setStyle (const std::string& value) void ColumnRecur::measure (Task& task, unsigned int& minimum, unsigned int& maximum) { minimum = maximum = 0; - if (task.has (_name)) { if (_style == "default" || diff --git a/src/columns/ColStart.cpp b/src/columns/ColStart.cpp index 88a9332c2..ae6f9f4cd 100644 --- a/src/columns/ColStart.cpp +++ b/src/columns/ColStart.cpp @@ -58,13 +58,14 @@ void ColumnStart::setStyle (const std::string& value) void ColumnStart::measure (Task& task, unsigned int& minimum, unsigned int& maximum) { minimum = maximum = 0; - if (task.has (_name)) { if (_style == "active") minimum = maximum = utf8_width (context.config.get ("active.indicator")); else ColumnTypeDate::measure (task, minimum, maximum); + + // TODO Throw on bad format. } } diff --git a/src/columns/ColTags.cpp b/src/columns/ColTags.cpp index 3d45dbe64..8d33348d0 100644 --- a/src/columns/ColTags.cpp +++ b/src/columns/ColTags.cpp @@ -75,7 +75,6 @@ void ColumnTags::setStyle (const std::string& value) void ColumnTags::measure (Task& task, unsigned int& minimum, unsigned int& maximum) { minimum = maximum = 0; - if (task.has (_name)) { if (_style == "indicator") diff --git a/src/columns/ColTypeDate.cpp b/src/columns/ColTypeDate.cpp index e2f19d56f..8bff07304 100644 --- a/src/columns/ColTypeDate.cpp +++ b/src/columns/ColTypeDate.cpp @@ -72,7 +72,6 @@ ColumnTypeDate::ColumnTypeDate () void ColumnTypeDate::measure (Task& task, unsigned int& minimum, unsigned int& maximum) { minimum = maximum = 0; - if (task.has (_name)) { Datetime date (task.get_date (_name)); diff --git a/src/columns/ColUDA.cpp b/src/columns/ColUDA.cpp index 8115e16a3..cbb657590 100644 --- a/src/columns/ColUDA.cpp +++ b/src/columns/ColUDA.cpp @@ -71,7 +71,6 @@ bool ColumnUDAString::validate (const std::string& value) const void ColumnUDAString::measure (Task& task, unsigned int& minimum, unsigned int& maximum) { minimum = maximum = 0; - if (task.has (_name)) { if (_style == "default") @@ -159,7 +158,6 @@ bool ColumnUDANumeric::validate (const std::string& value) const void ColumnUDANumeric::measure (Task& task, unsigned int& minimum, unsigned int& maximum) { minimum = maximum = 0; - if (task.has (_name)) { if (_style == "default") @@ -239,7 +237,6 @@ bool ColumnUDADate::validate (const std::string& value) const void ColumnUDADate::measure (Task& task, unsigned int& minimum, unsigned int& maximum) { minimum = maximum = 0; - if (task.has (_name)) { if (_style == "default") @@ -345,7 +342,6 @@ bool ColumnUDADuration::validate (const std::string& value) const void ColumnUDADuration::measure (Task& task, unsigned int& minimum, unsigned int& maximum) { minimum = maximum = 0; - if (task.has (_name)) { if (_style == "default") diff --git a/src/columns/Column.cpp b/src/columns/Column.cpp index dbf14e1dd..685a2cf1f 100644 --- a/src/columns/Column.cpp +++ b/src/columns/Column.cpp @@ -145,7 +145,7 @@ void Column::factory (std::map & all) //////////////////////////////////////////////////////////////////////////////// void Column::uda (std::map & all) { - // For each UDA, instantiate and initialize ColumnUDA(). + // For each UDA, instantiate and initialize ColumnUDA. std::set udas; for (const auto& i : context.config)