From f351bf6dec72026108fec4ed009649421af240c7 Mon Sep 17 00:00:00 2001 From: Paul Beckingham Date: Wed, 22 Sep 2010 22:23:24 -0400 Subject: [PATCH] Minor Edits - Corrected typo in tips file. - Added explanatory comment regarding dependency chains. --- i18n/tips.en-US | 2 +- src/dependency.cpp | 30 ++++++++++++++++++++++++++++-- 2 files changed, 29 insertions(+), 3 deletions(-) diff --git a/i18n/tips.en-US b/i18n/tips.en-US index 4e095bc37..91bdde192 100644 --- a/i18n/tips.en-US +++ b/i18n/tips.en-US @@ -60,7 +60,7 @@ verb, like "call" or "clean" or "get". % Don't like the name of a command? Create an alias. % -You can choose whether your searches are case sensitive or not, by setting +You can choose whether your searches are case sensitive or not, by running 'task config search.case.sensitive yes' % Back up your data files by making copies of the ~/.taskrc file and ~/.task diff --git a/src/dependency.cpp b/src/dependency.cpp index 858e8e7db..d22711f09 100644 --- a/src/dependency.cpp +++ b/src/dependency.cpp @@ -34,7 +34,8 @@ extern Context context; //////////////////////////////////////////////////////////////////////////////// -static bool followUpstream (const Task&, const Task&, const std::vector &, std::vector &); +static bool followUpstream (const Task&, const Task&, const std::vector &, + std::vector &); //////////////////////////////////////////////////////////////////////////////// // A task is blocked if it depends on tasks that are pending or waiting. @@ -182,11 +183,36 @@ static bool followUpstream ( //////////////////////////////////////////////////////////////////////////////// // Determine whether a dependency chain is being broken, assuming that 'task' is // either completed or deleted. +// +// [1] --> 2 Chain broken +// Nag message generated +// Repair offered: 1 dep:-2 +// +// [1] --> 2 Chain broken +// --> 3 Nag message generated +// Repair offered: 1 dep:-2,-3 +// +// 1 --> [2] - +// +// 1 --> [2] - +// 3 --> +// +// 1 --> [2] --> 3 Chain broken +// Nag message generated +// Repair offered: 2 dep:-3 +// 1 dep:-2,3 +// +// 1 --> [2] --> 3 Chain broken +// 4 --> --> 5 Nag message generated +// Repair offered: 2 dep:-3,-5 +// 1 dep:3,5 +// 4 dep:3,5 +// bool dependencyChainBroken (Task& task) { if (task.has ("depends")) { - std::cout << "# chain broken\n"; + std::cout << "# chain broken?\n"; return true; }