gergely/taskwarrior-2.x
1
0
Fork 0
Code Issues Actions Packages Projects Releases 1 Wiki Activity

Task

Browse Source 
- When a duration fails to parse during ::modify, it must raise an exception,
  and not silently skip the attribute.
This commit is contained in:
Paul Beckingham
2014-06-15 23:34:43 -04:00
parent 64c9cbe943
commit ef3deaad4a
1 changed files with 14 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/Task.cpp
View File

@@ -2034,8 +2034,6 @@ void Task::modify (modType type, bool text_required /* = false */)
{ {
// The duration is stored in raw form, but it must still be valid, // The duration is stored in raw form, but it must still be valid,
// and therefore is parsed first. // and therefore is parsed first.
try
{
Eval e; Eval e;
e.addSource (domSource); e.addSource (domSource);
e.addSource (namedDates); e.addSource (namedDates);
@@ -2050,9 +2048,8 @@ void Task::modify (modType type, bool text_required /* = false */)
set (name, value); set (name, value);
++modCount; ++modCount;
} }
} else
throw format ("The duration value '{1}' is not supported.", value);
catch (...) { /* NOP */ }
} }
// Need handling for numeric types, used by UDAs. // Need handling for numeric types, used by UDAs.