From e4987ea7e0c8223f32f56630d4d7d9ea60a4cdcc Mon Sep 17 00:00:00 2001 From: "Dustin J. Mitchell" Date: Sun, 18 Dec 2022 16:41:57 +0000 Subject: [PATCH] use OpenFlags::default to avoid maintaining explicit defaults --- taskchampion/taskchampion/src/storage/sqlite.rs | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/taskchampion/taskchampion/src/storage/sqlite.rs b/taskchampion/taskchampion/src/storage/sqlite.rs index bc51e5e2b..cfc7bdd83 100644 --- a/taskchampion/taskchampion/src/storage/sqlite.rs +++ b/taskchampion/taskchampion/src/storage/sqlite.rs @@ -87,11 +87,11 @@ impl SqliteStorage { // Open (or create) database let db_file = directory.as_ref().join("taskchampion.sqlite3"); - let mut flags = OpenFlags::SQLITE_OPEN_READ_WRITE - | OpenFlags::SQLITE_OPEN_NO_MUTEX - | OpenFlags::SQLITE_OPEN_URI; - if create_if_missing { - flags |= OpenFlags::SQLITE_OPEN_CREATE; + let mut flags = OpenFlags::default(); + // default contains SQLITE_OPEN_CREATE, so remove it if we are not to + // create a DB when missing. + if !create_if_missing { + flags.remove(OpenFlags::SQLITE_OPEN_CREATE); } let con = Connection::open_with_flags(db_file, flags)?;