From c72e1ea379626e94a4dfe359f107d13395a911bf Mon Sep 17 00:00:00 2001 From: Tomas Babej Date: Sat, 16 Jan 2021 12:40:53 -0500 Subject: [PATCH] cmake: Do not send local context when for make review/reproduce The Dockerfiles for make review and make reproduce targets do not use any information from the local taskwarrior git repository. Use STDIN-based syntax to ensure local context is not sent to the daemon. See: https://docs.docker.com/engine/reference/commandline/build/#build-with-- --- CMakeLists.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 6fc04840a..7c16ec58f 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -155,13 +155,13 @@ foreach (doc_FILE ${doc_FILES}) endforeach (doc_FILE) add_custom_command(OUTPUT run-review - COMMAND docker build -f scripts/review-dockerfile --build-arg PR=$(PR) -t taskwarrior-review:$(PR) . + COMMAND docker build --build-arg PR=$(PR) -t taskwarrior-review:$(PR) - < scripts/review-dockerfile COMMAND docker run --rm --hostname pr-$(PR) -it taskwarrior-review:$(PR) bash || : ) add_custom_target(review DEPENDS run-review) add_custom_command(OUTPUT run-reproduce - COMMAND docker build -f scripts/reproduce-dockerfile --build-arg RELEASE=$(RELEASE) -t taskwarrior-reproduce:$(RELEASE) . + COMMAND docker build --build-arg RELEASE=$(RELEASE) -t taskwarrior-reproduce:$(RELEASE) - < scripts/reproduce-dockerfile COMMAND docker run --rm --hostname tw-$(RELEASE) -it taskwarrior-reproduce:$(RELEASE) bash || : ) add_custom_target(reproduce DEPENDS run-reproduce)