From c3ecfac4f5bae4d563ea7b8b9e0c32c883188921 Mon Sep 17 00:00:00 2001 From: Paul Beckingham Date: Sat, 5 Dec 2020 16:18:15 -0500 Subject: [PATCH] Revert "[clang-tidy] Use const reference instead of initializing string" This reverts commit ab170e34df7d4685499df731e45d2171a9535b97. --- src/sort.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sort.cpp b/src/sort.cpp index df71a1804..3f13f9201 100644 --- a/src/sort.cpp +++ b/src/sort.cpp @@ -242,7 +242,7 @@ static bool sort_compare (int left, int right) // UDAs. else if ((column = Context::getContext ().columns[field]) != nullptr) { - const std::string& type = column->type (); + std::string type = column->type (); if (type == "numeric") { auto left_real = strtof (((*global_data)[left].get_ref (field)).c_str (), nullptr);