From b7726bce21a767d052aa90c8f1a64ba75415c62b Mon Sep 17 00:00:00 2001 From: Paul Beckingham Date: Thu, 26 Nov 2009 09:41:47 -0500 Subject: [PATCH] Bug Fix - #329 task shell convert all characters to lowercase - Fixed bug that inadvertently converted the entire command line to lower case in the shell, rather than just the command, for testing against the "quit" string (thanks to Juergen Daubert). --- AUTHORS | 2 ++ ChangeLog | 2 ++ src/command.cpp | 8 ++++---- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/AUTHORS b/AUTHORS index 291ddc51b..570ba41ef 100644 --- a/AUTHORS +++ b/AUTHORS @@ -41,3 +41,5 @@ Thanks to the following, who submitted detailed bug reports and excellent sugges Ian Mortimer Zach Frazier Joe Pulliam + Juergen Daubert + diff --git a/ChangeLog b/ChangeLog index 8dff14de3..851f36d47 100644 --- a/ChangeLog +++ b/ChangeLog @@ -5,6 +5,8 @@ + Fixed bug that was causing the 'completed' report to sort incorrectly. + Added feature to allow the user to quit when asked to confirm multiple changes. Now task asks "Proceed with change? (Yes/no/all/quit)". + + Fixed bug #321 where all shell input was converted to lower case (thanks + to Juergen Daubert). ------ old releases ------------------------------ diff --git a/src/command.cpp b/src/command.cpp index 7dad0ebbe..4dab68b67 100644 --- a/src/command.cpp +++ b/src/command.cpp @@ -1178,11 +1178,11 @@ void handleShell () command = ""; std::getline (std::cin, command); - command = lowerCase (trim (command)); + command = trim (command); - if (command.length () > 0 && - command.length () <= quit.length () && - command == quit.substr (0, command.length ())) + if (command.length () > 0 && + command.length () <= quit.length () && + lowerCase (command) == quit.substr (0, command.length ())) { keepGoing = false; }