gergely/taskwarrior-2.x
1
0
Fork 0
Code Issues Actions Packages Projects Releases 1 Wiki Activity

Performance: Removed unnecessary std::string::substr in high-traffic code

Browse Source
This commit is contained in:
Paul Beckingham
2015-11-01 16:10:49 -05:00
parent 25b7f42810
commit b5c4bf0a6d
4 changed files with 37 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/Color.cpp
View File

@@ -140,8 +140,8 @@ Color::Color (const std::string& spec)
}
// greyN/grayN, where 0 <= N <= 23.
else if (word.substr (0, 4) == "grey" ||
word.substr (0, 4) == "gray")
else if (! word.compare (0, 4, "grey", 4) ||
! word.compare (0, 4, "gray", 4))
{
index = atoi (word.substr (4).c_str ());
if (index < 0 || index > 23)
@@ -162,7 +162,7 @@ Color::Color (const std::string& spec)
}
// rgbRGB, where 0 <= R,G,B <= 5.
else if (word.substr (0, 3) == "rgb")
else if (! word.compare (0, 3, "rgb", 3))
{
index = atoi (word.substr (3).c_str ());
if (word.length () != 6 ||
@@ -194,7 +194,7 @@ Color::Color (const std::string& spec)
}
// colorN, where 0 <= N <= 255.
else if (word.substr (0, 5) == "color")
else if (! word.compare (0, 5, "color", 5))
{
index = atoi (word.substr (5).c_str ());
if (index < 0 || index > 255)