From ac309b4ff1c1559803c939fc209884d2bb1f02b3 Mon Sep 17 00:00:00 2001 From: Tomas Babej Date: Sun, 6 Dec 2020 11:37:27 -0500 Subject: [PATCH] tests: Skip the diagnostics test on Ubuntu 16.04 This is a byproduct of recent bump to C++17 compliant compilers. Ubuntu 16.04 does not have C++17 compliant compiler, but it's still useful to for us to test 2.5.3 there as the branch does not actually use any of the C++17 features not available on gcc on Ubuntu. --- test/diag.t | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/test/diag.t b/test/diag.t index ef4208064..ed744d020 100755 --- a/test/diag.t +++ b/test/diag.t @@ -28,6 +28,7 @@ import sys import os +import platform import unittest # Ensure python finds the local simpletap module sys.path.append(os.path.dirname(os.path.abspath(__file__))) @@ -43,6 +44,10 @@ class TestDiagnostics(TestCase): self.t.config("taskd.trust", "strict") self.t.config("taskd.credentials", "us/me/xxx") + @unittest.skipIf( + getattr(platform, 'dist', None) == None or 'xenial' == platform.dist()[-1], + 'Skipping diagnostics test on Ubuntu 16.04, as it lacks full C++17 support' + ) def test_diagnostics(self): """Task diag output, so we can monitor platforms""" self.t.activate_hooks()