gergely/taskwarrior-2.x
1
0
Fork 0
Code Issues Actions Packages Projects Releases 1 Wiki Activity

ViewTask

Browse Source 
- Improved locality, for readability, while debugging column TW-1417.
This commit is contained in:
Paul Beckingham
2014-09-20 14:11:59 -04:00
parent 5c15111bb1
commit 9bb1dbbd4d
1 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/ViewTask.cpp
View File

@@ -170,7 +170,6 @@ std::string ViewTask::render (std::vector <Task>& data, std::vector <int>& seque
int sum_minimal = std::accumulate (minimal.begin (), minimal.end (), 0); int sum_minimal = std::accumulate (minimal.begin (), minimal.end (), 0);
int sum_ideal = std::accumulate (ideal.begin (), ideal.end (), 0); int sum_ideal = std::accumulate (ideal.begin (), ideal.end (), 0);
// Calculate final column widths. // Calculate final column widths.
int overage = _width - sum_minimal - all_extra; int overage = _width - sum_minimal - all_extra;
context.debug (format ("ViewTask::render min={1} ideal={2} overage={3} width={4}", context.debug (format ("ViewTask::render min={1} ideal={2} overage={3} width={4}",
@@ -234,10 +233,6 @@ std::string ViewTask::render (std::vector <Task>& data, std::vector <int>& seque
max_lines = headers[c].size (); max_lines = headers[c].size ();
} }
// Output string.
std::string out;
_lines = 0;
// Render column headers. // Render column headers.
std::string left_margin = std::string (_left_margin, ' '); std::string left_margin = std::string (_left_margin, ' ');
std::string extra = std::string (_extra_padding, ' '); std::string extra = std::string (_extra_padding, ' ');
@@ -248,6 +243,8 @@ std::string ViewTask::render (std::vector <Task>& data, std::vector <int>& seque
std::string intra_odd = context.color () ? _intra_odd.colorize (intra) : intra; std::string intra_odd = context.color () ? _intra_odd.colorize (intra) : intra;
std::string intra_even = context.color () ? _intra_even.colorize (intra) : intra; std::string intra_even = context.color () ? _intra_even.colorize (intra) : intra;
std::string out;
_lines = 0;
for (unsigned int i = 0; i < max_lines; ++i) for (unsigned int i = 0; i < max_lines; ++i)
{ {
out += left_margin + extra; out += left_margin + extra;