gergely/taskwarrior-2.x
1
0
Fork 0
Code Issues Actions Packages Projects Releases 1 Wiki Activity

Variant

Browse Source 
- The partial match operator now expects length(left) > length(right).
This commit is contained in:
Paul Beckingham
2014-05-27 15:33:58 -04:00
parent ef412d0588
commit 7f56187748
3 changed files with 4 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/Variant.cpp
View File

@@ -761,8 +761,6 @@ bool Variant::operator_partial (const Variant& other) const
case type_real: right.cast (type_string); return left._string == right._string;
case type_string:
{
// Why the "if" instead of "min"? This is an attempt to eliminate one
// std::string::substr call.
int left_length = left._string.length ();
if (left_length == 0)
return false;
@@ -772,9 +770,9 @@ bool Variant::operator_partial (const Variant& other) const
return false;
if (left_length < right_length)
return left._string == right._string.substr (0, left_length);
else
return left._string.substr (0, right_length) == right._string;
return false;
return left._string.substr (0, right_length) == right._string;
}
// TODO Implement same-day comparison.
case type_date: left.cast (type_date); return left._date == right._date;