Tests - Less verbose hooks.on-*.t tests

This commit is contained in:
Renato Alves
2015-02-15 17:34:25 +00:00
parent 1b218d68f5
commit 7cd42b5d2f
4 changed files with 179 additions and 114 deletions

View File

@@ -48,11 +48,14 @@ class TestHooksOnAdd(TestCase):
self.t.hooks.add_default(hookname, log=True)
code, out, err = self.t(("add", "foo"))
self.t.hooks[hookname].assertTriggered()
self.t.hooks[hookname].assertTriggeredCount(1)
self.t.hooks[hookname].assertExitcode(0)
logs = self.t.hooks[hookname].get_logs()
self.assertEqual(self.t.hooks[hookname].get_logs()["output"]["msgs"][0], "FEEDBACK")
hook = self.t.hooks[hookname]
hook.assertTriggered()
hook.assertTriggeredCount(1)
hook.assertExitcode(0)
logs = hook.get_logs()
self.assertEqual(logs["output"]["msgs"][0], "FEEDBACK")
def test_onadd_builtin_reject(self):
"""on-add-reject - a well-behaved, failing, on-add hook."""
@@ -60,11 +63,14 @@ class TestHooksOnAdd(TestCase):
self.t.hooks.add_default(hookname, log=True)
code, out, err = self.t.runError(("add", "foo"))
self.t.hooks[hookname].assertTriggered()
self.t.hooks[hookname].assertTriggeredCount(1)
self.t.hooks[hookname].assertExitcode(1)
logs = self.t.hooks[hookname].get_logs()
self.assertEqual(self.t.hooks[hookname].get_logs()["output"]["msgs"][0], "FEEDBACK")
hook = self.t.hooks[hookname]
hook.assertTriggered()
hook.assertTriggeredCount(1)
hook.assertExitcode(1)
logs = hook.get_logs()
self.assertEqual(logs["output"]["msgs"][0], "FEEDBACK")
def test_onadd_builtin_misbehave1(self):
"""on-add-misbehave1 - does not consume input."""
@@ -72,11 +78,14 @@ class TestHooksOnAdd(TestCase):
self.t.hooks.add_default(hookname, log=True)
code, out, err = self.t.runError(("add", "foo"))
self.t.hooks[hookname].assertTriggered()
self.t.hooks[hookname].assertTriggeredCount(1)
self.t.hooks[hookname].assertExitcode(1)
logs = self.t.hooks[hookname].get_logs()
self.assertEqual(self.t.hooks[hookname].get_logs()["output"]["msgs"][0], "FEEDBACK")
hook = self.t.hooks[hookname]
hook.assertTriggered()
hook.assertTriggeredCount(1)
hook.assertExitcode(1)
logs = hook.get_logs()
self.assertEqual(logs["output"]["msgs"][0], "FEEDBACK")
def test_onadd_builtin_misbehave2(self):
"""on-add-misbehave2 - does not emit JSON."""
@@ -85,10 +94,11 @@ class TestHooksOnAdd(TestCase):
code, out, err = self.t.runError(("add", "foo"))
self.assertIn("Hook Error: Expected 1 JSON task(s), found 0", err)
self.t.hooks[hookname].assertTriggered()
self.t.hooks[hookname].assertTriggeredCount(1)
self.t.hooks[hookname].assertExitcode(0)
logs = self.t.hooks[hookname].get_logs()
hook = self.t.hooks[hookname]
hook.assertTriggered()
hook.assertTriggeredCount(1)
hook.assertExitcode(0)
def test_onadd_builtin_misbehave3(self):
"""on-add-misbehave3 - emits additional JSON."""
@@ -97,10 +107,11 @@ class TestHooksOnAdd(TestCase):
code, out, err = self.t.runError(("add", "foo"))
self.assertIn("Hook Error: Expected 1 JSON task(s), found 2", err)
self.t.hooks[hookname].assertTriggered()
self.t.hooks[hookname].assertTriggeredCount(1)
self.t.hooks[hookname].assertExitcode(0)
logs = self.t.hooks[hookname].get_logs()
hook = self.t.hooks[hookname]
hook.assertTriggered()
hook.assertTriggeredCount(1)
hook.assertExitcode(0)
def test_onadd_builtin_misbehave4(self):
"""on-add-misbehave4 - emits different task JSON."""
@@ -109,11 +120,14 @@ class TestHooksOnAdd(TestCase):
code, out, err = self.t.runError(("add", "foo"))
self.assertIn("Hook Error: JSON must be for the same task:", err)
self.t.hooks[hookname].assertTriggered()
self.t.hooks[hookname].assertTriggeredCount(1)
self.t.hooks[hookname].assertExitcode(0)
logs = self.t.hooks[hookname].get_logs()
self.assertEqual(self.t.hooks[hookname].get_logs()["output"]["msgs"][0], "FEEDBACK")
hook = self.t.hooks[hookname]
hook.assertTriggered()
hook.assertTriggeredCount(1)
hook.assertExitcode(0)
logs = hook.get_logs()
self.assertEqual(logs["output"]["msgs"][0], "FEEDBACK")
def test_onadd_builtin_misbehave5(self):
"""on-add-misbehave5 - emits syntactically wrong JSON."""
@@ -122,12 +136,15 @@ class TestHooksOnAdd(TestCase):
code, out, err = self.t.runError(("add", "foo"))
self.assertIn("Hook Error: JSON syntax error in: {\"}", err)
self.t.hooks[hookname].assertTriggered()
self.t.hooks[hookname].assertTriggeredCount(1)
self.t.hooks[hookname].assertExitcode(0)
self.t.hooks[hookname].assertInvalidJSONOutput()
logs = self.t.hooks[hookname].get_logs()
self.assertEqual(self.t.hooks[hookname].get_logs()["output"]["msgs"][0], "FEEDBACK")
hook = self.t.hooks[hookname]
hook.assertTriggered()
hook.assertTriggeredCount(1)
hook.assertExitcode(0)
hook.assertInvalidJSONOutput()
logs = hook.get_logs()
self.assertEqual(logs["output"]["msgs"][0], "FEEDBACK")
def test_onadd_builtin_misbehave6(self):
"""on-add-misbehave6 - emits incomplete JSON."""
@@ -136,11 +153,14 @@ class TestHooksOnAdd(TestCase):
code, out, err = self.t.runError(("add", "foo"))
self.assertIn("Hook Error: JSON Object missing 'uuid' attribute.", err)
self.t.hooks[hookname].assertTriggered()
self.t.hooks[hookname].assertTriggeredCount(1)
self.t.hooks[hookname].assertExitcode(0)
logs = self.t.hooks[hookname].get_logs()
self.assertEqual(self.t.hooks[hookname].get_logs()["output"]["msgs"][0], "FEEDBACK")
hook = self.t.hooks[hookname]
hook.assertTriggered()
hook.assertTriggeredCount(1)
hook.assertExitcode(0)
logs = hook.get_logs()
self.assertEqual(logs["output"]["msgs"][0], "FEEDBACK")
if __name__ == "__main__":
from simpletap import TAPTestRunner