Task: Project attributes are exempt from DOM expansion
This commit is contained in:
32
src/Task.cpp
32
src/Task.cpp
@@ -2003,19 +2003,27 @@ void Task::modify (modType type, bool text_required /* = false */)
|
|||||||
! column->modifiable ())
|
! column->modifiable ())
|
||||||
throw format (STRING_INVALID_MOD, name, value);
|
throw format (STRING_INVALID_MOD, name, value);
|
||||||
|
|
||||||
// Try to evaluate 'value'. It might work.
|
// String type attributes only get DOM resolution, no eval.
|
||||||
Variant evaluatedValue;
|
Variant evaluatedValue;
|
||||||
try
|
if (name != "project" || Lexer::isDOM (value))
|
||||||
{
|
{
|
||||||
Eval e;
|
// Try to evaluate 'value'. It might work.
|
||||||
e.addSource (domSource);
|
try
|
||||||
e.addSource (namedDates);
|
{
|
||||||
contextTask = *this;
|
Eval e;
|
||||||
e.evaluateInfixExpression (value, evaluatedValue);
|
e.addSource (domSource);
|
||||||
}
|
e.addSource (namedDates);
|
||||||
|
contextTask = *this;
|
||||||
|
e.evaluateInfixExpression (value, evaluatedValue);
|
||||||
|
}
|
||||||
|
|
||||||
// Ah, fuck it.
|
// Ah, fuck it.
|
||||||
catch (...)
|
catch (...)
|
||||||
|
{
|
||||||
|
evaluatedValue = Variant (value);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
else
|
||||||
{
|
{
|
||||||
evaluatedValue = Variant (value);
|
evaluatedValue = Variant (value);
|
||||||
}
|
}
|
||||||
@@ -2160,7 +2168,7 @@ void Task::modify (modType type, bool text_required /* = false */)
|
|||||||
++modCount;
|
++modCount;
|
||||||
}
|
}
|
||||||
|
|
||||||
// String type columns are not eval'd.
|
// String type columns are not eval'd. Welll, not much.
|
||||||
else if (column->type () == "string")
|
else if (column->type () == "string")
|
||||||
{
|
{
|
||||||
std::string strValue = (std::string) evaluatedValue;
|
std::string strValue = (std::string) evaluatedValue;
|
||||||
|
|||||||
Reference in New Issue
Block a user