gergely/taskwarrior-2.x
1
0
Fork 0
Code Issues Actions Packages Projects Releases 1 Wiki Activity

Variant: Convert durations into dates as implicitly anchored around now

Browse Source 
The _period attribute holds the number of seconds that the Duration
holds, while _date attribute holds the number of seconds since the
beginning of unix epoch (also known as epoch time). As such, it does not
make sense to convert _period directly into _date.

Interpret _period as offset relative to current unix epoch time.

Closes #2390.
This commit is contained in:
Tomas Babej
2021-01-17 22:56:37 -05:00
parent 5e68165556
commit 7242accb58
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/Variant.cpp
View File

@@ -1930,7 +1930,9 @@ void Variant::cast (const enum type new_type)
case type_real: _real = static_cast<double>(_date); break;
case type_string: _string = (std::string) *this; break;
case type_date: break;
case type_duration: _duration = _date; break;
// TODO: Not exactly correct (should duration convert into date?), but
// currently needed for symmetry, which is assumed by operators.
case type_duration: _duration = _date - time (nullptr); break;
}
break;
@@ -1941,7 +1943,7 @@ void Variant::cast (const enum type new_type)
case type_integer: _integer = (long long) _duration; break;
case type_real: _real = static_cast<double>(_duration); break;
case type_string: _string = (std::string) *this; break;
case type_date: _date = _duration; break;
case type_date: _date = time (nullptr) + _duration; break;
case type_duration: break;
}
break;