gergely/taskwarrior-2.x
1
0
Fork 0
Code Issues Actions Packages Projects Releases 1 Wiki Activity

TDB2: Move gc() processing to TF2::load_tasks()

Browse Source 
Reduce the amount of copies necessary for TDB2::gc() by moving the GC
processing to the Task object source - TF2::load_tasks().

This entangles TDB2 and TF2 more than previously, but leads to huge
performance benefits:
 - "next"   performance test down 21%
 - "list"   performance test down 11%
 - "all"    performance test down  4%
 - "export" performance test down  9%

The "gc" measurement is down 96% for all performance tests.  This is a
result of moving the actual processing into TF2::load_gc() and not
measuring the time taken by that function as "gc" time.
This commit is contained in:
Wilhelm Schuermann
2015-11-08 21:05:08 +01:00
parent 7b8df7a439
commit 6dc30a9a1a
2 changed files with 106 additions and 120 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/TDB2.h
View File

@@ -59,7 +59,9 @@ public:
void clear_lines ();
void commit ();
void load_tasks ();
Task load_task (const std::string&);
void load_gc (Task&);
void load_tasks (bool from_gc = false);
void load_lines ();
// ID <--> UUID mapping.
@@ -71,10 +73,8 @@ public:
void clear ();
const std::string dump ();
private:
void dependency_scan ();
public:
bool _read_only;
bool _dirty;
bool _loaded_tasks;
@@ -114,7 +114,7 @@ public:
void commit ();
void get_changes (std::vector <Task>&);
void revert ();
int gc ();
void gc ();
int next_id ();
int latest_id ();