gergely/taskwarrior-2.x
1
0
Fork 0
Code Issues Actions Packages Projects Releases 1 Wiki Activity

Column: Removed unnecessary base class virtuals

Browse Source
This commit is contained in:
Paul Beckingham
2015-07-18 19:04:55 -04:00
parent 079a2dd56d
commit 575caffe13
2 changed files with 5 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
src/columns/Column.cpp
View File

@@ -253,34 +253,6 @@ bool Column::validate (std::string& input)
return input.length () ? true : false; return input.length () ? true : false;
} }
////////////////////////////////////////////////////////////////////////////////
// No L10N.
void Column::measure (const std::string&, unsigned int&, unsigned int&)
{
throw std::string ("Virtual method Column::measure not overridden.");
}
////////////////////////////////////////////////////////////////////////////////
// No L10N.
void Column::measure (Task&, unsigned int&, unsigned int&)
{
throw std::string ("Virtual method Column::measure not overridden.");
}
////////////////////////////////////////////////////////////////////////////////
// No L10N.
void Column::render (std::vector <std::string>&, const std::string&, int, Color&)
{
throw std::string ("Virtual method Column::render not overridden.");
}
////////////////////////////////////////////////////////////////////////////////
// No L10N.
void Column::render (std::vector <std::string>&, Task&, int, Color&)
{
throw std::string ("Virtual method Column::render not overridden.");
}
//////////////////////////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////////////////////////
// No L10N. // No L10N.
bool Column::can_modify () bool Column::can_modify ()
@@ -289,10 +261,3 @@ bool Column::can_modify ()
} }
//////////////////////////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////////////////////////
// No L10N.
std::string Column::modify (std::string& value)
{
throw std::string ("Virtual method Column::modify not overridden.");
}
////////////////////////////////////////////////////////////////////////////////

10
src/columns/Column.h
View File

@@ -58,13 +58,13 @@ public:
virtual void setReport (const std::string& value) { _report = value; } virtual void setReport (const std::string& value) { _report = value; }
virtual bool validate (std::string&); virtual bool validate (std::string&);
virtual void measure (const std::string&, unsigned int&, unsigned int&); virtual void measure (const std::string&, unsigned int&, unsigned int&) {};
virtual void measure (Task&, unsigned int&, unsigned int&); virtual void measure (Task&, unsigned int&, unsigned int&) {};
virtual void renderHeader (std::vector <std::string>&, int, Color&); virtual void renderHeader (std::vector <std::string>&, int, Color&);
virtual void render (std::vector <std::string>&, const std::string&, int, Color&); virtual void render (std::vector <std::string>&, const std::string&, int, Color&) {};
virtual void render (std::vector <std::string>&, Task&, int, Color&); virtual void render (std::vector <std::string>&, Task&, int, Color&) {};
virtual bool can_modify (); virtual bool can_modify ();
virtual std::string modify (std::string&); virtual std::string modify (std::string& input) { return input; };
protected: protected:
std::string _name; std::string _name;