From fbc97c871bee77bb949c92715dc3cb568d9a6925 Mon Sep 17 00:00:00 2001 From: dbr Date: Tue, 15 Jun 2021 12:13:15 +1000 Subject: [PATCH 1/4] Test on Windows+macOS --- .github/workflows/tests.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 1ea9f23c0..f526447ee 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -16,8 +16,12 @@ jobs: rust: - "1.47" # MSRV - "stable" + os: + - ubuntu-latest + - macOS-latest + - windows-latest - name: "Test - Rust ${{ matrix.rust }}" + name: "Test - Rust ${{ matrix.rust }} on ${{ matrix.os }" steps: - uses: actions/checkout@v1 From 41c5cc842d41f893b2324b2c6f6c6e9c0d69bff5 Mon Sep 17 00:00:00 2001 From: dbr Date: Tue, 15 Jun 2021 12:16:09 +1000 Subject: [PATCH 2/4] Typo --- .github/workflows/tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index f526447ee..b756ab0eb 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -21,7 +21,7 @@ jobs: - macOS-latest - windows-latest - name: "Test - Rust ${{ matrix.rust }} on ${{ matrix.os }" + name: "Test - Rust ${{ matrix.rust }} on ${{ matrix.os }}" steps: - uses: actions/checkout@v1 From 5769b2070289cfc86c88f15ce8bfc3321ecd9e2b Mon Sep 17 00:00:00 2001 From: dbr Date: Tue, 15 Jun 2021 12:20:55 +1000 Subject: [PATCH 3/4] Important missing line to make CI actually run on matrix.os --- .github/workflows/tests.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index b756ab0eb..0e4836a2a 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -22,6 +22,7 @@ jobs: - windows-latest name: "Test - Rust ${{ matrix.rust }} on ${{ matrix.os }}" + runs-on: ${{ matrix.os }} steps: - uses: actions/checkout@v1 From 2a2aef2b25c37b48fe5077bed1321ccf7b8e52d9 Mon Sep 17 00:00:00 2001 From: dbr Date: Tue, 15 Jun 2021 12:25:04 +1000 Subject: [PATCH 4/4] Maybe this time --- .github/workflows/tests.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 0e4836a2a..6baef4519 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -9,8 +9,6 @@ on: jobs: test: - runs-on: ubuntu-latest - strategy: matrix: rust: