From 529161b7111b38b659f700d19b23767cc7b76cce Mon Sep 17 00:00:00 2001
From: Uli Martens <uli@youam.net>
Date: Mon, 23 Jan 2012 06:24:51 -0500
Subject: [PATCH] Bug #905

- The problem was that the routine dependencyIsCircular() changed its behaviour
  in git revision 726fc33fe4ae26801b566fe85404935e7ee0529d, and the new version
  only checked tasks by id - but all completed/deleted tasks have the id0, which
  led to the problem.  The fix is extremelly simple, just get the dependencies
  by uuid instead of by id.

Signed-off-by: Paul Beckingham <paul@beckingham.net>
---
 AUTHORS            | 2 +-
 src/dependency.cpp | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/AUTHORS b/AUTHORS
index 88f50526f..80459e45b 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -64,6 +64,7 @@ The following submitted code, packages or analysis, and deserve special thanks:
   Barton Meeks
   Martin Klepsch
   Ralph Bean
+  Uli Martens
 
 Thanks to the following, who submitted detailed bug reports and excellent
 suggestions:
@@ -103,7 +104,6 @@ suggestions:
   Pete Lewis
   Stefan Hacker
   Alan Barton
-  Uli Martens
   Jonathan Hankins
   Andreas Kalex
   Adam Wolk
diff --git a/src/dependency.cpp b/src/dependency.cpp
index 86a9aba1a..c127d0bc3 100644
--- a/src/dependency.cpp
+++ b/src/dependency.cpp
@@ -117,7 +117,7 @@ void dependencyGetBlocking (const Task& task, std::vector <Task>& blocking)
 bool dependencyIsCircular (const Task& task)
 {
   std::stack <Task> s;
-  std::vector <int> deps_current;
+  std::vector <std::string> deps_current;
 
   std::string task_uuid = task.get ("uuid");