gergely/taskwarrior-2.x
1
0
Fork 0
Code Issues Actions Packages Projects Releases 1 Wiki Activity

Revert "[clang-tidy] Use .empty instead of comparing size"

Browse Source 
This reverts commit a331cceded.
This commit is contained in:
Paul Beckingham
2020-12-05 16:18:15 -05:00
parent b2d46a1eba
commit 3e0a428185
18 changed files with 132 additions and 132 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/sort.cpp
View File

@@ -55,7 +55,7 @@ void sort_tasks (
global_keys = split (keys, ',');
// Only sort if necessary.
if (!order.empty())
if (order.size ())
std::stable_sort (order.begin (), order.end (), sort_compare);
Context::getContext ().time_sort_us += timer.total_us ();
@@ -68,7 +68,7 @@ void sort_projects (
for (auto& project : allProjects)
{
const std::vector <std::string> parents = extractParents (project.first);
if (!parents.empty())
if (parents.size ())
{
// if parents exist: store iterator position of last parent
std::list <std::pair <std::string, int>>::iterator parent_pos;
@@ -184,10 +184,10 @@ static bool sort_compare (int left, int right)
auto left_string = (*global_data)[left].get_ref (field);
auto right_string = (*global_data)[right].get_ref (field);
if (!left_string.empty() && right_string.empty())
if (left_string != "" && right_string == "")
return true;
if (left_string.empty() && !right_string.empty())
if (left_string == "" && right_string != "")
return false;
if (left_string == right_string)
@@ -207,10 +207,10 @@ static bool sort_compare (int left, int right)
if (left_string == right_string)
continue;
if (left_string.empty() && !right_string.empty())
if (left_string == "" && right_string != "")
return ascending;
if (!left_string.empty() && right_string.empty())
if (left_string != "" && right_string == "")
return !ascending;
// Sort on the first dependency.
@@ -274,9 +274,9 @@ static bool sort_compare (int left, int right)
else
{
// Empty values are unconditionally last, if no custom order was specified.
if (left_string.empty())
if (left_string == "")
return false;
else if (right_string.empty())
else if (right_string == "")
return true;
return ascending ? (left_string < right_string)
@@ -289,10 +289,10 @@ static bool sort_compare (int left, int right)
auto left_string = (*global_data)[left].get_ref (field);
auto right_string = (*global_data)[right].get_ref (field);
if (!left_string.empty() && right_string.empty())
if (left_string != "" && right_string == "")
return true;
if (left_string.empty() && !right_string.empty())
if (left_string == "" && right_string != "")
return false;
if (left_string == right_string)