gergely/taskwarrior-2.x
1
0
Fork 0
Code Issues Actions Packages Projects Releases 1 Wiki Activity

Revert "[clang-tidy] Simplify boolean expressions"

Browse Source 
This reverts commit 51870dff34.
This commit is contained in:
Paul Beckingham
2020-12-05 16:18:15 -05:00
parent 623d5ceb59
commit 364b4ea8bd
8 changed files with 51 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/Task.cpp
View File

@@ -190,7 +190,10 @@ void Task::setAsNow (const std::string& att)
////////////////////////////////////////////////////////////////////////////////
bool Task::has (const std::string& name) const
{
return data.find (name) != data.end ();
if (data.find (name) != data.end ())
return true;
return false;
}
////////////////////////////////////////////////////////////////////////////////
@@ -1046,7 +1049,7 @@ int Task::getAnnotationCount () const
////////////////////////////////////////////////////////////////////////////////
bool Task::hasAnnotations () const
{
return annotation_count != 0;
return annotation_count ? true : false;
}
////////////////////////////////////////////////////////////////////////////////
@@ -1293,7 +1296,10 @@ bool Task::hasTag (const std::string& tag) const
// Concrete tags.
auto tags = split (get ("tags"), ',');
return std::find (tags.begin (), tags.end (), tag) != tags.end ();
if (std::find (tags.begin (), tags.end (), tag) != tags.end ())
return true;
return false;
}
////////////////////////////////////////////////////////////////////////////////
@@ -1362,7 +1368,7 @@ void Task::substitute (
const std::string& to,
const std::string& flags)
{
bool global = (flags.find ('g') != std::string::npos);
bool global = (flags.find ('g') != std::string::npos ? true : false);
// Get the data to modify.
std::string description = get ("description");