From 312f77f7030a3686c8d4d96d85d0e20696bbf644 Mon Sep 17 00:00:00 2001 From: Tomas Babej Date: Fri, 23 Apr 2021 22:47:27 -0400 Subject: [PATCH] performance: Do not use Pig to extract raw line content --- src/Task.cpp | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/Task.cpp b/src/Task.cpp index 8ab25c571..aa837b587 100644 --- a/src/Task.cpp +++ b/src/Task.cpp @@ -580,13 +580,14 @@ void Task::parse (const std::string& input) if (input[0] == '[') { - Pig pig (input); - std::string line; - if (pig.skip ('[') && - pig.getUntil (']', line) && - pig.skip (']') && - (pig.skip ('\n') || pig.eos ())) + // Not using Pig to parse here (which would be idiomatic), because we + // don't need to differentiate betwen utf-8 and normal characters. + // Pig's scanning the string can be expensive. + auto ending_bracket = input.find_last_of (']'); + if (ending_bracket != std::string::npos) { + std::string line = input.substr(1, ending_bracket); + if (line.length () == 0) throw std::string ("Empty record in input.");