From 2f15bb8fa5994012926fac99bcd2a1ed52597866 Mon Sep 17 00:00:00 2001 From: Renato Alves Date: Tue, 28 Jul 2015 20:01:39 +0100 Subject: [PATCH] Test: Revert recurrence.t test as per comment The comment mentions one behaviour but the test was performing another. It was also failing for a different reason, which is filters with no matches always exit with non-zero. If the correct behaviour is indeed expiring all recurring tasks, the test must use runError instead. Also added a TODO for easier finding. --- test/recurrence.t | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/recurrence.t b/test/recurrence.t index 6608508f7..a1d62c174 100755 --- a/test/recurrence.t +++ b/test/recurrence.t @@ -149,15 +149,15 @@ class TestRecurrenceUntil(TestCase): code, out, err = self.t("list rc.verbose:nothing") self.assertEqual(out.count("one"), 3) - # This test currently failing, probably because the 'until' is + # TODO This test currently failing, probably because the 'until' is # propagated to the instances, and expires them also. This is certainly # the way it has been behaving for a while, but is not the original # intention. Perhaps it is now the de facto functionality, in which - # change the 3 to a 0. + # change the 3 to a 0. The change to 0 also implies use of runError as + # exit code for empty filters is always != 0 self.t.faketime("+24h") code, out, err = self.t("list rc.verbose:nothing") - #self.assertEqual(out.count("one"), 3) - self.assertEqual(out.count("one"), 0) + self.assertEqual(out.count("one"), 3) class TestRecurrenceTasks(TestCase):