gergely/taskwarrior-2.x
1
0
Fork 0
Code Issues Actions Packages Projects Releases 1 Wiki Activity

Bug #917

Browse Source 
- Fixed bug #917, which mis-encoded quotes (thanks to Uli Martens).
- Added unit tests.
- Minor unrelated edits.
This commit is contained in:
Paul Beckingham
2012-02-02 22:58:36 -05:00
parent 89b5c91a35
commit 2ce9322a28
5 changed files with 70 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/util.cpp
View File

@@ -492,14 +492,12 @@ unsigned burndown_size (unsigned ntasks)
////////////////////////////////////////////////////////////////////////////////
// Encode values prior to serialization.
// " -> &dquot;
// [ -> &open;
// ] -> &close;
const std::string encode (const std::string& value)
{
std::string modified = value;
str_replace (modified, "\"", "&dquot;");
str_replace (modified, "[", "&open;");
str_replace (modified, "]", "&close;");
@@ -521,14 +519,14 @@ const std::string decode (const std::string& value)
std::string modified = value;
// Supported encodings.
str_replace (modified, "&dquot;", "\"");
str_replace (modified, """, "'");
str_replace (modified, "&open;", "[");
str_replace (modified, "&close;", "]");
// Support for deprecated encodings. These cannot be removed or old files
// will not be parsable. Not just old files - completed.data can contain
// tasks formatted/encoded using these.
str_replace (modified, "&dquot;", "\"");
str_replace (modified, """, "'");
str_replace (modified, "&squot;", "'"); // Deprecated 2.0
str_replace (modified, ",", ","); // Deprecated 2.0
str_replace (modified, ":", ":"); // Deprecated 2.0