Deprecated Feature Removal

- Removed deprecated 'echo.command' setting, in favor of the 'header' and
  'affected' verbosity tokens.

src/commands/CmdLog.cpp

@@ -67,8 +67,7 @@ int CmdLog::execute (std::string& output)
     context.footnote (onProjectChange (task));
   context.tdb2.commit ();
 
-  if (context.verbose ("affected") ||
-      context.config.getBoolean ("echo.command")) // Deprecated 2.0
+  if (context.verbose ("affected"))
     output = std::string (STRING_CMD_LOG_LOGGED) + "\n";
 
   return rc;

src/commands/CmdShow.cpp

@@ -146,7 +146,6 @@ int CmdShow::execute (std::string& output)
     " displayweeknumber"
     " dom"
     " due"
-    " echo.command"                      // Deprecated 2.0
     " edit.verbose"                      // Deprecated 2.0
     " editor"
     " exit.on.missing.db"

src/feedback.cpp

@@ -314,11 +314,8 @@ std::string renderAttribute (const std::string& name, const std::string& value,
 //    <string>
 void feedback_affected (const std::string& effect)
 {
-  if (context.verbose ("affected") ||
-      context.config.getBoolean ("echo.command")) // Deprecated 2.0
-  {
+  if (context.verbose ("affected"))
     std::cout << effect << "\n";
-  }
 }
 
 ////////////////////////////////////////////////////////////////////////////////
@@ -329,12 +326,9 @@ void feedback_affected (const std::string& effect)
 //    {1}    Quantity
 void feedback_affected (const std::string& effect, int quantity)
 {
-  if (context.verbose ("affected") ||
-      context.config.getBoolean ("echo.command")) // Deprecated 2.0
-  {
+  if (context.verbose ("affected"))
     std::cout << format (effect, quantity)
               << "\n";
-  }
 }
 
 ////////////////////////////////////////////////////////////////////////////////
@@ -346,8 +340,7 @@ void feedback_affected (const std::string& effect, int quantity)
 //    {2}    Description
 void feedback_affected (const std::string& effect, const Task& task)
 {
-  if (context.verbose ("affected") ||
-      context.config.getBoolean ("echo.command")) // Deprecated 2.0
+  if (context.verbose ("affected"))
   {
     if (task.id)
       std::cout << format (effect, task.id, task.get ("description"))
@@ -392,8 +385,7 @@ void feedback_special_tags (const Task& task, const std::string& tag)
 //    Unblocked <id> '<description>'
 void feedback_unblocked (const Task& task)
 {
-  if (context.verbose ("affected") ||
-      context.config.getBoolean ("echo.command")) // Deprecated 2.0
+  if (context.verbose ("affected"))
   {
     // Get a list of tasks that depended on this task.
     std::vector <Task> blocked;

src/legacy.cpp

@@ -148,8 +148,7 @@ std::string legacyCheckForDeprecatedVariables ()
         it->first.substr (it->first.length () - 12) == ".annotations")
       deprecated.push_back (it->first);
 
-    if (it->first == "echo.command"      ||
-        it->first == "edit.verbose"      ||
+    if (it->first == "edit.verbose"      ||
         it->first == "next"              ||
         it->first == "annotations"       ||
         it->first == "export.ical.class")