TW-1636: UUID with numeric-only first segment is not parsed properly

- Switched Nibbler::getUUID to Nibbler::getPartialUUID, which caused partial
  UUID mathcing to fail sometimes.
- Changed precedence to search for UUID before ID, which solves the numeric
  UUID problem.
This commit is contained in:
Paul Beckingham
2015-08-08 00:49:54 -04:00
parent 9cdabf288e
commit 2a621a4367
2 changed files with 8 additions and 9 deletions

View File

@@ -255,24 +255,23 @@ bool DOM::get (const std::string& name, const Task& task, Variant& value)
std::string uuid; std::string uuid;
bool proceed = false; bool proceed = false;
if (n.getInt (id) && n.depleted ()) if (n.getPartialUUID (uuid) && n.depleted ())
{ {
if (id == task.id) if (uuid == task.get ("uuid"))
ref = task; ref = task;
else else
context.tdb2.get (id, ref); context.tdb2.get (uuid, ref);
proceed = true; proceed = true;
} }
else else
{ {
n.restore (); if (n.getInt (id) && n.depleted ())
if (n.getUUID (uuid) && n.depleted ())
{ {
if (uuid == task.get ("uuid")) if (id == task.id)
ref = task; ref = task;
else else
context.tdb2.get (uuid, ref); context.tdb2.get (id, ref);
proceed = true; proceed = true;
} }

View File

@@ -115,7 +115,7 @@ bool TF2::get (int id, Task& task)
} }
//////////////////////////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////////////////////////
// Locate task by uuid. // Locate task by uuid, which may be a partial UUID.
bool TF2::get (const std::string& uuid, Task& task) bool TF2::get (const std::string& uuid, Task& task)
{ {
if (! _loaded_tasks) if (! _loaded_tasks)
@@ -123,7 +123,7 @@ bool TF2::get (const std::string& uuid, Task& task)
for (auto& i : _tasks) for (auto& i : _tasks)
{ {
if (i.get ("uuid") == uuid) if (closeEnough (i.get ("uuid"), uuid, uuid.length ()))
{ {
task = i; task = i;
return true; return true;