gergely/taskwarrior-2.x
1
0
Fork 0
Code Issues Actions Packages Projects Releases 1 Wiki Activity

Task: Improved CppCoreGuideline compliance

Browse Source
This commit is contained in:
Paul Beckingham
2016-01-31 16:05:00 -05:00
parent 08b7b5b800
commit 15373daf85
2 changed files with 8 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/Task.cpp
View File

@@ -88,18 +88,6 @@ std::map <std::string, std::vector <std::string>> Task::customOrder;
static const std::string dummy (""); static const std::string dummy ("");
////////////////////////////////////////////////////////////////////////////////
Task::Task ()
: data ()
, id (0)
, urgency_value (0.0)
, recalc_urgency (true)
, is_blocked (false)
, is_blocking (false)
, annotation_count (0)
{
}
//////////////////////////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////////////////////////
// The uuid and id attributes must be exempt from comparison. // The uuid and id attributes must be exempt from comparison.
// //

19
src/Task.h
View File

@@ -57,13 +57,11 @@ public:
static float urgencyAgeMax; static float urgencyAgeMax;
public: public:
Task (); // Default constructor Task () = default; // Default constructor
bool operator== (const Task&); // Comparison operator bool operator== (const Task&); // Comparison operator
Task (const std::string&); // Parse Task (const std::string&); // Parse
Task (const json::object*); // Parse Task (const json::object*); // Parse
std::map <std::string, std::string> data;
void parse (const std::string&); void parse (const std::string&);
std::string composeF4 () const; std::string composeF4 () const;
std::string composeJSON (bool decorate = false) const; std::string composeJSON (bool decorate = false) const;
@@ -75,14 +73,13 @@ public:
enum dateState {dateNotDue, dateAfterToday, dateLaterToday, dateEarlierToday, dateBeforeToday}; enum dateState {dateNotDue, dateAfterToday, dateLaterToday, dateEarlierToday, dateBeforeToday};
// Public data. // Public data.
int id; std::map <std::string, std::string> data {};
float urgency_value; int id {0};
bool recalc_urgency; float urgency_value {0.0};
bool recalc_urgency {true};
bool is_blocked; bool is_blocked {false};
bool is_blocking; bool is_blocking {false};
int annotation_count {0};
int annotation_count;
// Series of helper functions. // Series of helper functions.
static status textToStatus (const std::string&); static status textToStatus (const std::string&);