From 138360b7bc77c838aa62622ffde09ce2d027777a Mon Sep 17 00:00:00 2001 From: Wilhelm Schuermann Date: Thu, 5 Mar 2015 09:23:56 +0100 Subject: [PATCH] Hooks - Fixed on-modify hook regression which stopped hooks from modifying tasks. On a related note, more hooks tests are definitely needed. --- ChangeLog | 2 ++ src/Hooks.cpp | 1 + 2 files changed, 3 insertions(+) diff --git a/ChangeLog b/ChangeLog index 009c569ed..c6a422317 100644 --- a/ChangeLog +++ b/ChangeLog @@ -22,6 +22,8 @@ forks (thanks to Jens Erat). - Re-enabled hook script feedback when exiting with 0 exit status. - The 'info' command now shows virtual tags. +- Fixed major on-modify hooks regression where hooks could no longer modify + the tasks handed to them. ------ current release --------------------------- diff --git a/src/Hooks.cpp b/src/Hooks.cpp index f1f99d1c8..a2eb0cea8 100644 --- a/src/Hooks.cpp +++ b/src/Hooks.cpp @@ -358,6 +358,7 @@ void Hooks::onModify (const Task& before, Task& after) throw 0; // This is how hooks silently terminate processing. } } + after = Task (input[1]); } context.timer_hooks.stop ();