From 1302e69d5119b7c2b5c9b622acee88ea4e173e32 Mon Sep 17 00:00:00 2001 From: Renato Alves Date: Mon, 25 May 2015 18:15:31 +0100 Subject: [PATCH] Expected failures are now treated as skipped tests Before they were being treated as "passing" tests. Since this might cause them to be silently ignored, classifying them under "skipped" will ensure they won't go unnoticed. Expected failures != skipped. The former will always be executed. --- test/problems | 2 +- test/simpletap/__init__.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/test/problems b/test/problems index 6a188ee05..49e935840 100755 --- a/test/problems +++ b/test/problems @@ -30,7 +30,7 @@ if (open my $fh, '<', 'all.log') for sort {$skipped{$b} <=> $skipped{$a}} keys %skipped; print "\n"; - print "Expected failures\n"; + print "Expected failures (part of skipped)\n"; printf "%-32s %4d\n", $_, $expected{$_} for sort {$expected{$b} <=> $expected{$a}} keys %expected; } diff --git a/test/simpletap/__init__.py b/test/simpletap/__init__.py index 6e81d6529..501e88eaf 100644 --- a/test/simpletap/__init__.py +++ b/test/simpletap/__init__.py @@ -148,7 +148,7 @@ class TAPTestResult(unittest.result.TestResult): ) elif status == "EXPECTED_FAILURE": self.stream.writeln("{0} {1} - {2}".format( - color("ok", "green"), self.testsRun, desc) + color("skip", "yellow"), self.testsRun, desc) ) else: self.stream.writeln("{0} {1} - {2}".format(