gergely/taskwarrior-2.x
1
0
Fork 0
Code Issues Actions Packages Projects Releases 1 Wiki Activity

Test for bug 1192 - brace expansion.

Browse Source 
Commit 968d1c3 (Portability) introduced a bug with some very POSIX
compliant shells (eg dash), which don't do brace expansion.  So add a
test for that.

The test runs by adding a new protocol in Uri, sh+cp://path/.  This
protocol is not intended to be used normally, but is only for testing
the push and pull code.

Signed-off-by: Russell Steicke <russells@adelie.cx>
This commit is contained in:
Russell Steicke
2013-03-31 00:04:28 +08:00
committed by Paul Beckingham
parent 983e07ab01
commit 0cc7bc337d
8 changed files with 213 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

79
src/TransportShell.cpp Normal file
View File

@@ -0,0 +1,79 @@
////////////////////////////////////////////////////////////////////////////////
// taskwarrior - a command line task list manager.
//
// Copyright 2010 - 2013, Johannes Schlatow.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included
// in all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
// THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
// SOFTWARE.
//
// http://www.opensource.org/licenses/mit-license.php
//
////////////////////////////////////////////////////////////////////////////////
#define L10N // Localization complete.
#include <text.h>
#include <i18n.h>
#include <TransportShell.h>
#include <util.h>
////////////////////////////////////////////////////////////////////////////////
TransportShell::TransportShell(const Uri& uri) : Transport(uri)
{
_executable = "cp";
}
////////////////////////////////////////////////////////////////////////////////
void TransportShell::send(const std::string& source)
{
if (_uri._path == "")
throw std::string (STRING_TRANSPORT_SHELL_NOPATH);
// Is there more than one file to transfer?
// Then path has to end with a '/'
if (is_filelist(source) && !_uri.is_directory())
throw format (STRING_TRANSPORT_URI_NODIR, _uri._path);
_arguments.push_back (source);
_arguments.push_back (_uri._path);
if (execute ())
throw std::string (STRING_TRANSPORT_SHELL_FAIL);
}
////////////////////////////////////////////////////////////////////////////////
void TransportShell::recv(std::string target)
{
if (_uri._path == "")
throw std::string (STRING_TRANSPORT_SHELL_NOPATH);
// Is there more than one file to transfer?
// Then target has to end with a '/'
if (is_filelist(_uri._path) && !is_directory(target))
throw format (STRING_TRANSPORT_URI_NODIR, target);
_arguments.push_back (_uri._path);
_arguments.push_back (target);
if (execute ())
throw std::string (STRING_TRANSPORT_SHELL_FAIL);
}
////////////////////////////////////////////////////////////////////////////////