gergely/taskwarrior-2.x
1
0
Fork 0
Code Issues Actions Packages Projects Releases 1 Wiki Activity

TDB2

Browse Source 
- Disabled hook processing while processing hooks. This is because both ::add
  and ::modify can each add or modify tasks, and there is the potential for
  infinite recursion.
This commit is contained in:
Paul Beckingham
2014-09-09 23:37:29 -04:00
parent 7e35508bb4
commit 05ba58c56f
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/TDB2.cpp
View File

@@ -137,7 +137,10 @@ bool TF2::get (const std::string& uuid, Task& task)
//////////////////////////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////////////////////////
void TF2::add_task (Task& task) void TF2::add_task (Task& task)
{ {
bool enabled = context.hooks.enable (false);
context.hooks.onAdd (task); context.hooks.onAdd (task);
context.hooks.enable (enabled);
_tasks.push_back (task); // For subsequent queries _tasks.push_back (task); // For subsequent queries
_added_tasks.push_back (task); // For commit/synch _added_tasks.push_back (task); // For commit/synch
@@ -167,7 +170,10 @@ bool TF2::modify_task (const Task& task)
if (i->get ("uuid") == uuid) if (i->get ("uuid") == uuid)
{ {
Task hookTask (task); Task hookTask (task);
bool enabled = context.hooks.enable (false);
context.hooks.onModify (*i, hookTask); context.hooks.onModify (*i, hookTask);
context.hooks.enable (enabled);
*i = hookTask; *i = hookTask;
_modified_tasks.push_back (hookTask); _modified_tasks.push_back (hookTask);