Build
- Enabled compiler warnings, which were off. Yikes. - Fixed all compiler warnings on OSX.
This commit is contained in:
@@ -28,5 +28,5 @@ set (columns_SRCS Column.cpp Column.h
|
||||
add_library (columns STATIC ${columns_SRCS})
|
||||
|
||||
set (CMAKE_BUILD_TYPE debug)
|
||||
set (CMAKE_C_FLAGS_DEBUG "-ggdb3")
|
||||
set (CMAKE_C_FLAGS_RELEASE "-O3")
|
||||
set (CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} -ggdb3 -Wall")
|
||||
set (CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} -O3 -Wall")
|
||||
|
||||
@@ -75,7 +75,7 @@ void ColumnTags::measure (Task& task, int& minimum, int& maximum)
|
||||
split (all, tags, ',');
|
||||
std::vector <std::string>::iterator i;
|
||||
for (i = all.begin (); i != all.end (); ++i)
|
||||
if (i->length () > minimum)
|
||||
if ((int)i->length () > minimum)
|
||||
minimum = i->length () + 1;
|
||||
}
|
||||
}
|
||||
|
||||
@@ -47,7 +47,7 @@ ColumnUUID::~ColumnUUID ()
|
||||
|
||||
////////////////////////////////////////////////////////////////////////////////
|
||||
// Set the minimum and maximum widths for the value.
|
||||
void ColumnUUID::measure (Task& task, int& minimum, int& maximum)
|
||||
void ColumnUUID::measure (Task&, int& minimum, int& maximum)
|
||||
{
|
||||
if (_style == "default") minimum = maximum = 36;
|
||||
else if (_style == "short") minimum = maximum = 8;
|
||||
|
||||
@@ -174,25 +174,25 @@ void Column::renderHeader (
|
||||
}
|
||||
|
||||
////////////////////////////////////////////////////////////////////////////////
|
||||
void Column::measure (const std::string& value, int& minimum, int& maximum)
|
||||
void Column::measure (const std::string&, int&, int&)
|
||||
{
|
||||
throw std::string ("Virtual method Column::measure not overriden.");
|
||||
}
|
||||
|
||||
////////////////////////////////////////////////////////////////////////////////
|
||||
void Column::measure (Task& task, int& minimum, int& maximum)
|
||||
void Column::measure (Task&, int&, int&)
|
||||
{
|
||||
throw std::string ("Virtual method Column::measure not overriden.");
|
||||
}
|
||||
|
||||
////////////////////////////////////////////////////////////////////////////////
|
||||
void Column::render (std::vector <std::string>& lines, const std::string& value, int width, Color& color)
|
||||
void Column::render (std::vector <std::string>&, const std::string&, int, Color&)
|
||||
{
|
||||
throw std::string ("Virtual method Column::render not overriden.");
|
||||
}
|
||||
|
||||
////////////////////////////////////////////////////////////////////////////////
|
||||
void Column::render (std::vector <std::string>& lines, Task& task, int width, Color& color)
|
||||
void Column::render (std::vector <std::string>&, Task&, int, Color&)
|
||||
{
|
||||
throw std::string ("Virtual method Column::render not overriden.");
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user